Water heater with double shell heat exchanger